Skip to content

Fix the onnxfrontend didn't call DLLMain when exit#33641

Merged
sgbihu merged 3 commits intoopenvinotoolkit:masterfrom
sgbihu:fix_shutdown_protobuf
Jan 21, 2026
Merged

Fix the onnxfrontend didn't call DLLMain when exit#33641
sgbihu merged 3 commits intoopenvinotoolkit:masterfrom
sgbihu:fix_shutdown_protobuf

Conversation

@sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Jan 16, 2026

Details:

  • The static library link can't enter the DLLMain when dll unload.

Tickets:

@sgbihu sgbihu requested a review from a team as a code owner January 16, 2026 07:59
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: build OpenVINO cmake script / infra labels Jan 16, 2026
set(TARGET_NAME openvino_protobuf_shutdown)

add_library(${TARGET_NAME} STATIC shutdown_protobuf.cpp)
add_library(${TARGET_NAME} OBJECT shutdown_protobuf.cpp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add comment here that it must be preserved as OBJECT and not STATIC for windows build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@sgbihu
Copy link
Contributor Author

sgbihu commented Jan 18, 2026

build_jenkins

@sgbihu sgbihu force-pushed the fix_shutdown_protobuf branch from a9dc4f2 to 159fc2f Compare January 19, 2026 01:20
@sgbihu sgbihu added this to the 2026.0 milestone Jan 19, 2026
@sgbihu sgbihu force-pushed the fix_shutdown_protobuf branch from 159fc2f to 9a441be Compare January 19, 2026 05:09
@sgbihu sgbihu force-pushed the fix_shutdown_protobuf branch from b6999bd to 5a034b3 Compare January 19, 2026 22:18
@sgbihu
Copy link
Contributor Author

sgbihu commented Jan 20, 2026

build_jenkins

@sgbihu
Copy link
Contributor Author

sgbihu commented Jan 21, 2026

build_jenkins

@sgbihu sgbihu added this pull request to the merge queue Jan 21, 2026
Merged via the queue into openvinotoolkit:master with commit d906577 Jan 21, 2026
251 of 258 checks passed
@sgbihu sgbihu deleted the fix_shutdown_protobuf branch January 21, 2026 06:44
Naseer-010 pushed a commit to Naseer-010/openvino that referenced this pull request Feb 18, 2026
…3641)

### Details:
 - The static library link can't enter the DLLMain when dll unload.

### Tickets:
 - [CVS-179009](https://jira.devtools.intel.com/browse/CVS-179009)

---------

Co-authored-by: Denis Orlov <denis.orlov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build OpenVINO cmake script / infra category: Core OpenVINO Core (aka ngraph)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants